[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpcgen fixes



On Tue, Dec 16, 2008 at 06:25:26PM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1229399266 28800
> # Node ID 12c9b283b11f5e20b9dcc91e3d10a862da5d6e81
> # Parent  1ba824db09286ebc758e035211da2c533bbd1e0f
> rpcgen fixes
> 
> quad_t is not a portable type, but rather than force rpcgen
> every build, we just patch in the fixes needed.

IIRC, this will also help on Mac OS-X which lacked this.

> Also, since we ship the rpcgen-derived files in CVS, don't leave
> Makefile rules that could trigger during a normal build: make a special
> maintainer target for refreshing the derived sources.

ACK, good change. The automatic refresh was broken anyway, because
the generated files are needed from ../src before the build even
gets to qemud/. These generated files / wire protocol define ABI
and should never change for ordinary builds, so its safer to keep
generation of them an explicit maintainer task.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]