[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] __FUNCTION__ is not portable



"Daniel P. Berrange" <berrange redhat com> wrote:

> On Tue, Dec 16, 2008 at 06:50:44PM -0800, john levon sun com wrote:
>> # HG changeset patch
>> # User john levon sun com
>> # Date 1229399267 28800
>> # Node ID ee6ccfc062f49f514d7ae8924d5a596b18441fee
>> # Parent  b105e5a7cd6190e0b952a1587d7e80f39d02e63c
>> __FUNCTION__ is not portable
>>
>> __func__ is. Some places aren't covered by the back-compat define (why
>> is that there?)
>
> Not sure why we added that. Seems reasonable to just use __func__
> everywhere since that has broader compiler support

ACK from me, too.

Along with that, can you add a syntax-check rule to Makefile.maint
that will ensure that no uses of __FUNCTION__ sneak back in?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]