[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH 0/5: connection cloning support (WIP)



On Wed, Dec 17, 2008 at 11:21:34AM -0500, David Lively wrote:
> 
> It turned out to be a double-free.  Trivial fix below.
> 
> Dave
> 
> diff --git a/src/remote_internal.c b/src/remote_internal.c
> index 9245a2a..d6b94ff 100644
> --- a/src/remote_internal.c
> +++ b/src/remote_internal.c
> @@ -6423,10 +6423,10 @@ remoteDomainQueueEvent(virConnectPtr conn, XDR
> *xdr)
>          return;
>  
>      if (virDomainEventQueuePush(priv->domainEvents,
> -                                event) < 0)
> +                                event) < 0) {
>          DEBUG0("Error adding event to queue");
> -
> -    virDomainEventFree(event);
> +        virDomainEventFree(event);
> +    }
>  }
>  
>  /** remoteDomainEventFired:


Thanks, I've committed this patch

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]