[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Unify pool-create-as and pool-define-as xml building



On Wed, Dec 17, 2008 at 01:24:41PM -0500, Cole Robinson wrote:
> The attached patch unifies the xml building and command line option
> registering for the virsh pool-*-as commands, fixing a few bugs in the
> process:
> 
> - pool-define-as was creating <host> without a name attribute
>   (rhbz 476708)
> - pool-create-as wasn't adding a closing tag to its <host> block
> - pool-create-as didn't have the source-name option
> 
> All seem like a good justification for not duplicating the logic. The
> patch ends up looking a bit bizarre, but it's mostly just moving the xml
> building from create-as into a separate function buildPoolXML, and then
> wiring it up.

This makes sense. ACK.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]