[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Pull vc-list-files from gnulib, and update.



On Fri, Feb 01, 2008 at 02:01:47PM +0100, Jim Meyering wrote:
> "Richard W.M. Jones" <rjones redhat com> wrote:
> > Jim Meyering wrote:
> >> Now that I've added the vc-list-files script to gnulib,
> >> this patch makes libvirt's bootstrap pull it from there.
> >>
> >> Changes from the previous version of the script:
> >>
> >>   I reintroduced support for mercurial (only lightly tested),
> >>   and rearranged the directory-existence tests so git is first.
> >
> > Bit unclear - what do we actually use this script for?
> 
> Hi Rich,
> 
> It's used only in the "make syntax-check" rules in Makefile.maint.
> 
> >> +elif test -d .hg; then
> >> +  exec hg locate "$dir/*"
> >
> > 'hg manifest' command does the same thing.
> 
> Yes, it's similar.
> Unfortunately, using "hg manifest" (which this script did use
> up until about a year ago) is problematic, since its output
> format changed at some point between 0.9.2 and 0.9.5.
> 
> But then, I'm hardly a mercurial expert.  If someone can tell me of a
> better way to make hg report just the names of version controlled files
> in a given directory, portably, I'll be happy to adapt.

The hg locate command does look like the better bet to me - particularly
becasue it allows explicit filtering - manifest gives you all files whether
you want them or not.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]