[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] mark some diagnostics for translation



On Mon, Feb 04, 2008 at 12:36:29PM +0100, Jim Meyering wrote:
> This makes it so some diagnostics emitted via the error function
> are checked for use of "_(...)" when you run "make syntax-check",
> and fixes the ones that lacked that:
> 
> 	Enable the sc_unmarked_diagnostics test and correct all violations
> 	involving the "error" function.
> 	* Makefile.cfg (local-checks-to-skip): Remove from skip list.
> 
> Then, at the end, a second patch:
> 
> 	Mark a string for translation.
> 	* src/virsh.c: Add a "%s" and wrap with _(...).
> 
> Note that technically, it doesn't make sense to translate
> a diagnostic like this (there are several like this):
> 
>         error (conn, VIR_ERR_RPC, _("maxids > REMOTE_DOMAIN_ID_LIST_MAX"));
> 
> However, if it's worth emitting the diagnostic, then I think it's worth
> making it a little more useful to someone not reading the code, e.g.,
> 
>         too many domains (maximum is %d)
> 
> If no one objects, I'll convert the ones below.

  I am fine with the principle and the patch. Once commited I should 
push the pot file to the Fedora translation services.

   thanks,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]