[Libvir] [PATCH] change a Disk/Nic of inactive domain

[Ryan Scott]

Resurrecting a two-week old thread...

Was a version of this patch ever committed?  I don't see it, but I may 
have missed it.

I used an earlier version of the patch to fix a problem we've noticed, 
but I would like to see the final version of the patch.

Thanks,
Ryan

S.Sakamoto wrote:
>>>> These struct definitions *intentionally* private.
>>> Oops, I did not notice it...
>>>
>>> I revised a patch not to access the struct data directly.
>> In principle this patch looks good.  If no one else objects, I'll commit 
>> this, with a few of my own fixes (below).
>>
>> Rich.
>>
>> +        (obj->stringval) && !strcmp((char*)obj->stringval, "hvm"))
>>
>> I'm going to use STREQ macro here instead of !strcmp.
>>
>> +    if (ctxt)
>> +        xmlXPathFreeContext(ctxt);
>>
>> There are a few potential double-frees on the cleanup path.  Need to set 
>> ctxt back to NULL after freeing it.
>>
> Thank you for improving my patch!
> Because it looks like that no one else objects, please commit this.
> 
> Thanks,
> Shigeki Sakamoto.
> 
> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list