[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [patch 1/2] Create directory for saving iptables rules



On Thu, 2008-02-07 at 05:03 -0500, Daniel Veillard wrote:
> On Thu, Feb 07, 2008 at 09:16:47AM +0100, Jim Meyering wrote:
> > Mark McLoughlin <markmc redhat com> wrote:
> > 
> > > +
> > >      if ((err = writeRules(rules->path, rules->rules, rules->nrules))) {
> > >          qemudLog(QEMUD_WARN, "Failed to saves iptables rules to %s : %s",
> > >                   rules->path, strerror(err));
> > 
> > +1, modulo what looks like a missing comma after QEMUD_WARN
> 
>   Agreed :-) +1

	Nice catch Jim ... I'm still note quite sure why there was no warning
on that one ...

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]