[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: 2/16: Internal driver API



On Tue, Feb 12, 2008 at 10:41:54AM -0800, Dan Smith wrote:
> DB> +/**
> DB> +* _virNetwork:
> DB> +*
> DB> +* Internal structure associated to a storage pool
> DB> +*/
> 
> This looks like a copy-and-paste casualty.
> 
> DB> +struct _virStoragePool {
> DB> +    unsigned int magic;                  /* specific value to check */
> DB> +    int refs;                            /* reference count */
> DB> +    virConnectPtr conn;                  /* pointer back to the connection */
> DB> +    char *name;                          /* the storage pool external name */
> DB> +    unsigned char uuid[VIR_UUID_BUFLEN]; /* the storage pool unique identifier */
> DB> +};
> DB> +
> DB> +/**
> DB> +* _virNetwork:
> DB> +*
> DB> +* Internal structure associated to a storage volume
> DB> +*/
> 
> ...as does this.
> 
> DB> +
> DB> +/**
> DB> + * virStoragePoolGetConnect:
> DB> + * @pool: pointer to a poool
> DB> + *
> DB> + * Provides the connection pointer associated with a storage poolk.  The
>                                                                   ^^^^^
> Typo.

Thanks I'll fix all these.

> Don't you just hate completely superficial responses such as this 
> one? :)

Right, you're going on my list ;-P

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]