[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Enable another syntax-check rule.



On Thu, Feb 07, 2008 at 07:09:44PM +0100, Jim Meyering wrote:
> This one makes sure we don't use the "#ifdef HAVE_CONFIG_H" meme:
> 
> 	Enable another syntax-check rule.
> 	* Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h.
> 	* qemud/mdns.c: Remove "#ifdef HAVE_CONFIG_H".
> 	* Makefile.maint (sc_no_have_config_h): Tighten up regexp,
> 	so that the above mention of "HAVE_CONFIG_H" doesn't match.
> 	* .x-sc_no_have_config_h: New file, to exempt gnulib/ straggler.
> 
> Signed-off-by: Jim Meyering <meyering redhat com>

  I don't see any ack, looks fine to me, to the extend I understand
(i.e. not the perl part).
 +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]