[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: 0/16: Storage management APIs

On Tue, Feb 12, 2008 at 04:28:29AM +0000, Daniel P. Berrange wrote:
> The patch series that follows provides storage management APIs for dealing
> with local directories, local filesystems, remote filesystems, logical
> volumes (LVM), disk partitioning, and iSCSI. It will also soon support
> SCSI host adapters (including NPIV).
> I'll include comments inline with each patch. The final patch in the
> series also provides a 'storage.html' page for the website giving a fairly
> friendly overview of the storage pool types and their associated XML
> examples.
> Although included here, the one API i really don't like is the one for
> discovery virConnectDiscoverStoragePools, since its API is not flexible
> enough in terms of metadata it accepts. I will probably just leave this
> out next time around, since its not critical for the core functionality
> and can thus be  added later.
> Also TBD is a way to format a filesystem on a  volume, and how to clone
> an existing volume, and take a snapshot. These things can all be added
> at a later date.
> Finally it does not include the async job support. This is also best added
> once the core code is merged.

I've just sent out updates of the patch series, which I believe includs all
the bug fixes & suggestions raised in this thread - there were alot of replies
so there's a possibly i've missed one or two comments, but most should be

The storage_{driver,conf,backend} and all backends have been re-formated to
keep under 80 columns, with only a handful of exceptions where I didn't want
to wrap static constant strings.

All the new strings are marked for translations so make syntax-check passes.
Format strings on virReportError are now correct - gcc annotation picked up
a few bugs. The inclusion of bare 'errno' is mostly removed.

And all the other coments...

The patches should apply cleanly to today's CVS.

For convenience you can grab them all directly from


NB, only the patches prefixed with 'storage-XXXX' are submitted here.

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]