[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] take 2 [Re: write(2) may write less than the total requested



On Wed, 2008-02-20 at 16:42 +0100, Jim Meyering wrote:

> If I do as you suggest and move the safewrite definition into util.h,
> and make it static inline, then both problems go away.

	Make sure to try and build this with gcc-4.3.0 - remember that we
un-inlined xstrtol() because of:

  internal.h:272: error: inlining failed in call to 'xstrtol_i': call is unlikely and code size would grow

	Again, the option is to stop using -Winline, but it's probably about
time we figured out some proper way of sharing code between libvirt.so
and virsh etc. without adding it to the ABI.

	How about a libvirtutil libtool convenience (i.e. static) library?

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]