[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [RFC] 1/3 Base linux container support

On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote:
> This patch contains the base linux container support
> * new switch --with-lxc to enable support (off by default)

Any reason this can't be on-by-default ?  I know OpenVZ is off by default
but I'd like to see that on by default too. As it stands it never even
gets compiled by most people so we don't see whether it breaks. 

Support for Linux containers can be enabled/disable by user on the fly
just by rebooting into a new enough kernel, so we should enable it in
libvirt no matter what & probe at runtime if needed.

> * Add new source files to Makefile.am
> * Add define for lxc in driver.h
> * Add call to lxcRegister() in libvirt.c
> * Add define for errors from lxc in virterror.h
> * Add case for errors from lxc in virterror.c

Rest of this patch looks fine.

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]