[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] default hypervisor selection

I'm mostly with Dan Berrange here.  Surely an environment variable is
the right thing to do, and then later we can add some advanced probing
if the environment variable alone doesn't satisfy users.

The only problem I see is making the NULL case unpredictable or
introducing unreproducible bugs.  But I guess that's not very likely.

Dan's patch
is fine except it should include a DEBUG() statement so we have some
chance to gather information from bug reports about what it was
actually trying to connect to.  At the moment, the first DEBUG() isn't
done until after the URI is parsed, and URI parsing is quite likely to
be a failure point.


Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]