[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Avoid new "make syntax-check" failures.



On Fri, Feb 22, 2008 at 09:33:26PM +0100, Jim Meyering wrote:
> With recent changes, I introduced some new "make syntax-check"
> failures.  Also, there were two remaining invalid uses of write(2).
> This fixes all that.
> 
> 	Avoid new "make syntax-check" failures.
> 	* .x-sc_avoid_write: Exempt src/util-lib.c, too.
> 	* Makefile.maint (sc_unmarked_diagnostics): Filter out false positives.
> 	* src/storage_backend_fs.c (virStorageBackendFileSystemVolCreate):
> 	Use safewrite, not write.
> 	* src/storage_backend_logical.c (virStorageBackendLogicalBuildPool):
>         Likewise.

  makes sense to me, except the Makefile.maint regexps i can't decypher, +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]