[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] (for discussion) DHCP host mappings using 3 arrays API



On Tue, Feb 26, 2008 at 11:43:59AM +0100, Jim Meyering wrote:
> "Richard W.M. Jones" <rjones redhat com> wrote:
> > This patch is an evolution of the previous patch for implementing DHCP
> ...
> > +    if (maxmappings == 0) return 0;
> ...
> > +                if (col == 0) hwaddr = token;
> ...
> > +                if (!(*hwaddrs)[lines]) goto mem_error;
> 
> Hi Rich,
> 
> Is there a libvirt style convention that says whether
> a one-line if-block is written all on one line?
> I find it slightly easier to spot the conditional at a glance
> when the statement is on a separate line, but can certainly adapt
> to a different style.

I don't know ... Is there a libvirt manual of style?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]