[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] make qemud/'s rpcgen rules work



On Wed, Feb 27, 2008 at 07:26:15PM +0100, Jim Meyering wrote:
> I applied Rich's patch and found that qemud/remote_protocol.c
> was not automatically rebuilt.  Since the Makefile rule
> is an implicit one using a non-default suffix (.x),
> you have to tell make about the new suffix.
> In straight make, you'd have to add ".SUFFIXES: .x"
> but with automake, it is recommended to use the SUFFIXES variable:
> 
>         Make qemud/'s rpcgen rules work.
> 	* qemud/Makefile.am (SUFFIXES): Define to .x before implicit rule.
> 
> Signed-off-by: Jim Meyering <meyering redhat com>
> ---
>  qemud/Makefile.am |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/qemud/Makefile.am b/qemud/Makefile.am
> index 1e1f861..3094b18 100644
> --- a/qemud/Makefile.am
> +++ b/qemud/Makefile.am
> @@ -14,6 +14,7 @@ EXTRA_DIST = libvirtd.init.in libvirtd.sysconf default-network.xml \
>          libvirtd.conf
> 
>  if RPCGEN
> +SUFFIXES = .x
>  .x.c:
>  	rm -f $@
>  	rpcgen -c -o $@ $<

+1.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]