[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [Q] gnulib comment



Atsushi SAKAI <sakaia jp fujitsu com> wrote:
> Hi, Jim
>
> I have two questions on gnulib in libvirt.
>
> 1)tupe is typo?(I attach a patch.)
>   (I do not guess the correct words, it is jargon?)

Hi Atsushi,

Thank you for the patch.  That is indeed a typo.
I've attached a patch adding a ChangeLog entry,
for application to gnulib's git repository.

> 2)many NUL appeared on comment.
>   Is the normal comment on gnulib?
>   I think it should be NULL.

As Rich mentioned, NUL refers to the '\0' byte,
NULL refers to the (void*)0 pointer.

--------------------------------
[Bruno, to apply this, you can remove the two '>' and then
 run "git am THIS_MESSAGE". ]

>From 91c0911ee3358b445b0b1da7cba1f0f0f4dabc47 Mon Sep 17 00:00:00 2001
>From: Atsushi SAKAI <sakaia jp fujitsu com>
Date: Thu, 28 Feb 2008 12:09:45 +0100
Subject: [PATCH] lib/xsize.h: Fix typo in comment: s/tupe/type/.

---
 ChangeLog   |    4 ++++
 lib/xsize.h |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d831fee..6e4b5ec 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-02-28  Atsushi SAKAI  <sakaia jp fujitsu com>
+
+	* lib/xsize.h: Fix typo in comment: s/tupe/type/.
+
 2008-02-26  Karl Berry  <karl freefriends org>

 	Sync from Libtool:
diff --git a/lib/xsize.h b/lib/xsize.h
index 341fb16..2d99a6b 100644
--- a/lib/xsize.h
+++ b/lib/xsize.h
@@ -1,6 +1,6 @@
 /* xsize.h -- Checked size_t computations.

-   Copyright (C) 2003 Free Software Foundation, Inc.
+   Copyright (C) 2003, 2008 Free Software Foundation, Inc.

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -94,7 +94,7 @@ xmax (size_t size1, size_t size2)
 /* Multiplication of a count with an element size, with overflow check.
    The count must be >= 0 and the element size must be > 0.
    This is a macro, not an inline function, so that it works correctly even
-   when N is of a wider tupe and N > SIZE_MAX.  */
+   when N is of a wider type and N > SIZE_MAX.  */
 #define xtimes(N, ELSIZE) \
   ((N) <= SIZE_MAX / (ELSIZE) ? (size_t) (N) * (ELSIZE) : SIZE_MAX)

--
1.5.4.3.326.g7655e3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]