[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libvir] [PATCH] #include "config.h" needed



There is one file missing:

  #include "config.h"

which ought to be included at the beginning of every C file. If missing, it causes problems on Windows -- in particular the C99 keyword 'restrict' won't be recognised and that causes compile errors all over the place.

I've also changed a few <config.h> --> "config.h", which I think is more correct because config.h is a local file and should never come from the system include files (CC'd to Jim Meyering -- is this right in your opinion?)

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903
Index: qemud/mdns.c
===================================================================
RCS file: /data/cvs/libvirt/qemud/mdns.c,v
retrieving revision 1.2
diff -u -r1.2 mdns.c
--- qemud/mdns.c	11 Dec 2007 21:57:29 -0000	1.2
+++ qemud/mdns.c	3 Jan 2008 15:11:05 -0000
@@ -23,7 +23,7 @@
  */
 
 #ifdef HAVE_CONFIG_H
-#include <config.h>
+#include "config.h"
 #endif
 
 #include <time.h>
Index: qemud/remote.c
===================================================================
RCS file: /data/cvs/libvirt/qemud/remote.c,v
retrieving revision 1.18
diff -u -r1.18 remote.c
--- qemud/remote.c	11 Dec 2007 21:57:29 -0000	1.18
+++ qemud/remote.c	3 Jan 2008 15:11:07 -0000
@@ -20,7 +20,7 @@
  * Author: Richard W.M. Jones <rjones redhat com>
  */
 
-#include <config.h>
+#include "config.h"
 
 #include <sys/types.h>
 #include <sys/wait.h>
Index: src/bridge.c
===================================================================
RCS file: /data/cvs/libvirt/src/bridge.c,v
retrieving revision 1.7
diff -u -r1.7 bridge.c
--- src/bridge.c	11 Dec 2007 21:57:29 -0000	1.7
+++ src/bridge.c	3 Jan 2008 15:11:07 -0000
@@ -19,7 +19,7 @@
  *     Mark McLoughlin <markmc redhat com>
  */
 
-#include <config.h>
+#include "config.h"
 
 #ifdef WITH_QEMU
 
Index: src/openvz_driver.c
===================================================================
RCS file: /data/cvs/libvirt/src/openvz_driver.c,v
retrieving revision 1.13
diff -u -r1.13 openvz_driver.c
--- src/openvz_driver.c	26 Dec 2007 05:41:05 -0000	1.13
+++ src/openvz_driver.c	3 Jan 2008 15:11:08 -0000
@@ -27,7 +27,7 @@
 
 #ifdef WITH_OPENVZ
 
-#include <config.h>
+#include "config.h"
 
 #include <sys/types.h>
 #include <sys/poll.h>
Index: src/qparams.c
===================================================================
RCS file: /data/cvs/libvirt/src/qparams.c,v
retrieving revision 1.1
diff -u -r1.1 qparams.c
--- src/qparams.c	17 Dec 2007 10:07:56 -0000	1.1
+++ src/qparams.c	3 Jan 2008 15:11:08 -0000
@@ -20,6 +20,8 @@
  * Utility functions to help parse and assemble query strings.
  */
 
+#include "config.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]