[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] #include "config.h" needed



On Thu, Jan 03, 2008 at 03:13:37PM +0000, Richard W.M. Jones wrote:
> There is one file missing:
> 
>   #include "config.h"
> 
> which ought to be included at the beginning of every C file.  If 
> missing, it causes problems on Windows -- in particular the C99 keyword 
> 'restrict' won't be recognised and that causes compile errors all over 
> the place.

Ok.
 
> I've also changed a few <config.h> --> "config.h", which I think is more 
> correct because config.h is a local file and should never come from the 
> system include files (CC'd to Jim Meyering -- is this right in your 
> opinion?)

Yep, that sounds good.

Dan
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]