[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libvir] [patch 2/9] Fix minor iptables error logging issue



Fix a minor issue with some error reporting in the iptables
code - namely that we use errno after it may have been set
to something other than the error reported.

Signed-off-by: Mark McLoughlin <markmc redhat com>

Index: libvirt/src/iptables.c
===================================================================
--- libvirt.orig/src/iptables.c	2008-01-04 11:46:38.000000000 +0000
+++ libvirt.orig/src/iptables.c	2008-01-04 11:46:38.000000000 +0000
@@ -601,7 +601,7 @@ iptRulesReload(iptRules *rules)
 
         if ((retval = iptablesSpawn(WITH_ERRORS, rule->argv)))
             qemudLog(QEMUD_WARN, "Failed to remove iptables rule '%s' from chain '%s' in table '%s': %s",
-                     rule->rule, rules->chain, rules->table, strerror(errno));
+                     rule->rule, rules->chain, rules->table, strerror(retval));
 
         rule->argv[rule->flipflop] = orig;
     }

-- 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]