[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Repository for work-in-progress storage patches



A few comments:

You should put #include <config.h> at the very top of all your C files (before any other headers/defines), to avoid warnings.

There was one place where you'd used virFreeStoragePool, which should be virStoragePoolFree.

Functions such as 'virDomainDestroy' have changed their semantics in that they now free the virDomainPtr object. I understand why you do this (the domain no longer exists, so the object cannot be used), but it is a big change from the p.o.v. of those of us using proper garbage collection, and moreover it's an ABI change. Existing correct code which did 'virDomainDestroy (dom); virDomainFree (dom);' could now segfault.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]