[Libvir] Repository for work-in-progress storage patches

Jim Meyering jim at meyering.net
Sat Jan 19 18:09:31 UTC 2008


"Daniel P. Berrange" <berrange at redhat.com> wrote:
...

Since you're working on the weekend ;-), here are some
notices I'd begun to accumulate:

  There are a bunch of new uses of open64, which isn't portable.
  How about using AC_SYS_LARGEFILE in configure.in instead?
  Then you can use "open" everywhere.

  In storage_backend_loop.c, it looks like vol->target.path can be leaked.

  Just after that, I wondered if other vol->members could be leaked,
  but haven't yet looked at the cleanup-called vol-destroying
  function; it probably frees everything.




More information about the libvir-list mailing list