[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: make debug builds quiet by default



On Sat, Jan 19, 2008 at 05:11:26AM -0500, Daniel Veillard wrote:
> On Wed, Jan 16, 2008 at 09:56:16AM +0000, Richard W.M. Jones wrote:
> > Daniel P. Berrange wrote:
> > >How about this patch. I define VIR_DEBUG in src/internal.c. Each module
> > >which wants to output debug messages adds
> > >
> > >  #define DEBUG(fmt,...) VIR_DEBUG("driver", fmt, __VA_ARGS__)
> > >  #define DEBUG0(msg) VIR_DEBUG("driver", "%s", msg)
> > >
> > >Changing 'driver' to whatever their module name wants to be. All log
> > >messages get the function name included
> > 
> > +1, the patch looks fine to me.
> 
>   +1 too

Ok, I've committed this - with one change - instead of having to  specify
the filename manually I used __FILE__ macro.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]