[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Repository for work-in-progress storage patches



On Fri, Jan 18, 2008 at 07:44:41PM +0000, Richard W.M. Jones wrote:
> A few comments:
> 
> You should put #include <config.h> at the very top of all your C files 
> (before any other headers/defines), to avoid warnings.

I believe I've added that to all files I created now.

> There was one place where you'd used virFreeStoragePool, which should be 
> virStoragePoolFree.

Fixed that too.

I've push a new series of patches which fix these, and incorporate feedback
and fixes from Jim too. Should apply to current libvirt CVS.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]