[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS



"Daniel P. Berrange" <berrange redhat com> wrote:

> On Tue, Jan 22, 2008 at 04:00:49PM +0000, Daniel P. Berrange wrote:
>> This patch removes the use of PKG_CHECK_EXISTS which is only available in
>> new versions of pkg-config.  Instead we use the 3rd and 4th args of the
>> PKG_CHECK_MODULES macro to control the  if-found/not-found  behaviour. This
>> allows us to auto-disable features if they're missing, rather than aborting
>> the configure run. This patch also updates the SASL tests to support the
>> value 'check' for auto-enable/disable like the rest of the modules.
>>
>> With this applied I can successfully run the following on RHEL-4 hosts
>> with the default RPMs installed
>>
>>   ./autogen.sh --without-xen
>>   make
>>   make dist
>
> And now with a patch...

Looks good.
Does libvirt have a policy about keeping line lengths <= 80?
IMHO, everyone should, if only so that printed code and side-by-side
diffs fit in the page or window without truncation or wrapping.

Autoconf code is hard enough to read without wrapped lines,
so if you could wrap a few while you're at it, that'd be nice.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]