[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS

On Tue, Jan 22, 2008 at 04:04:13PM +0000, Richard W.M. Jones wrote:
> Daniel P. Berrange wrote:
> >On Tue, Jan 22, 2008 at 04:00:49PM +0000, Daniel P. Berrange wrote:
> >>This patch removes the use of PKG_CHECK_EXISTS which is only available in
> >>new versions of pkg-config.  Instead we use the 3rd and 4th args of the
> >>PKG_CHECK_MODULES macro to control the  if-found/not-found  behaviour. 
> >>This
> >>allows us to auto-disable features if they're missing, rather than 
> >>aborting
> >>the configure run. This patch also updates the SASL tests to support the
> >>value 'check' for auto-enable/disable like the rest of the modules.
> >>
> >>With this applied I can successfully run the following on RHEL-4 hosts
> >>with the default RPMs installed
> >>
> >>  ./autogen.sh --without-xen
> >>  make
> >>  make dist
> >
> >And now with a patch...
> +1, much needed.

 agreed :-)


Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]