[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS



On Tue, Jan 22, 2008 at 07:21:41PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> ...
> > Index: configure.in
> > ===================================================================
> > RCS file: /data/cvs/libvirt/configure.in,v
> > retrieving revision 1.121
> > diff -u -p -r1.121 configure.in
> > --- configure.in	19 Jan 2008 18:36:01 -0000	1.121
> > +++ configure.in	22 Jan 2008 17:21:27 -0000
> ...
> > -if test "z$with_libxml" = "zno" ; then
> > +if test "$with_libxml" = "no" ; then
> 
> It's good to leave some kind of prefix on tested values like that,
> since the $with_libxml value is user-settable.
> I.e., with your change, --with-libxml=-lt causes
> a syntax error in the configure script:
> 
>     ./configure: line 27674: test: -z: integer expression expected

  Oh, that's why, I always wondered why people had that strange
habit of adding a prefix, good to know !

  +1 for the patch too,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]