[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS



On Tue, Jan 22, 2008 at 05:39:54PM +0000, Daniel P. Berrange wrote:
> On Tue, Jan 22, 2008 at 04:00:49PM +0000, Daniel P. Berrange wrote:
> > This patch removes the use of PKG_CHECK_EXISTS which is only available in
> > new versions of pkg-config.  Instead we use the 3rd and 4th args of the
> > PKG_CHECK_MODULES macro to control the  if-found/not-found  behaviour. This
> > allows us to auto-disable features if they're missing, rather than aborting
> > the configure run. This patch also updates the SASL tests to support the
> > value 'check' for auto-enable/disable like the rest of the modules.
> > 
> > With this applied I can successfully run the following on RHEL-4 hosts
> > with the default RPMs installed
> > 
> >   ./autogen.sh --without-xen
> >   make
> >   make dist
> 
> Here's a second version of the patch. I needed to conditionally define
> the PKG_PROG_PKG_CONFIG  macro since that's no available on old RHEL-4.
> Second, I had to make make gnutls fallback to doing a AC_LIB/AC_HEADER
> check if pkg-config fails because ancient gnutls doesn't have pkgconfig
> support. Finally I also had to add another compatability define for 
> the gnutls_cipher_algorithm_t typedef.
> 
> With this all done, it now works correctly on both RHEL-4 and my F8
> boxes.

Ok, so there was a missing  'with_sasl=yes'  in the AC_CHECK_LIB
test for sasl, which caused it to be disabled even though it was
found. The nightly builds found this bug, because the server config
file test rejected the 'auth=sasl' config setting...

http://builder.virt-manager.org/module-libvirt--devel.html

I checked in the trivial fix

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]