Daniel Veillard wrote:
As pointed by Jay Gagnon on IRC, virDomainGetXMLDesc() was failing if the flags value was non-NULL, and looking at the source we still had a check there to fail if flags is non-zero (and we define 2 flags in virDomainXMLFlags, so this is clearly broken),
+1 for the patch. We define two flags of interest: VIR_DOMAIN_XML_SECURE = 1, /* dump security sensitive informations too */ VIR_DOMAIN_XML_INACTIVE = 2/* dump inactive domain informations */Of these only 'SECURE' is actually used. I'm not quite sure what the second one means, since to dump an inactive domain you'd just call virDomainGetXMLDesc on the inactive domain (?)
We probably ought to also document these in the API, and add the appropriate flags to virsh too.
Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Description: S/MIME Cryptographic Signature