[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] 2/8 Add framework for code style- and syntax-checking rules.



Jim Meyering <jim meyering net> wrote:

> Add framework for code style- and syntax-checking rules.
>
> Almost all tests are initially disabled via the list in Makefile.cfg.
> * Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free.
> Omit names of files that automake includes automatically.
> * .x-sc_avoid_if_before_free: New file.
> * build-aux/vc-list-files: Likewise.
> * build-aux/find-unnecessary-if-before-free: Likewise.
> * GNUmakefile, Makefile.cfg, Makefile.maint: New files.
>
> Signed-off-by: Jim Meyering <meyering redhat com>
> ---
>  .x-sc_avoid_if_before_free                |    4 +
>  GNUmakefile                               |   58 ++++
>  Makefile.am                               |    8 +-
>  Makefile.cfg                              |   62 ++++
>  Makefile.maint                            |  510 +++++++++++++++++++++++++++++

Note that Makefile.maint contains some tests that are not applicable
to libvirt.  They're disabled, after all.  However, I opted to leave the
unused rules in Makefile.maint even though they're probably never going
to be used here, just so that it's a little easier to keep libvirt's
copy of this file synchronized with the one in coreutils.

The idea is that if something needs to be changed, it can be changed
via Makefile.cfg.  Of course tests like the one for marked diagnostics
will have to be adapted to deal with libvirt-specific function names.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]