[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix diagnostic when execute openvz commands



On Tue, Jul 08, 2008 at 07:46:52PM +0400, Evgeniy Sokolov wrote:
> Index: openvz_driver.c
> ===================================================================
> RCS file: /data/cvs/libvirt/src/openvz_driver.c,v
> retrieving revision 1.23
> diff -u -p -r1.23 openvz_driver.c
> --- openvz_driver.c	7 Jul 2008 11:48:40 -0000	1.23
> +++ openvz_driver.c	8 Jul 2008 15:30:16 -0000
> @@ -257,7 +257,7 @@ static int openvzDomainShutdown(virDomai
>  
>      ret = virExec(dom->conn, (char **)cmdExec, &pid, -1, &outfd, &errfd);
>      if(ret == -1) {
> -        error(dom->conn, VIR_ERR_INTERNAL_ERROR, "Could not exec " VZLIST);
> +        error(dom->conn, VIR_ERR_INTERNAL_ERROR, "Could not exec " VZCTL);

This really needs to be changed to pass through gettext, eg

   error(dom->conn, VIR_ERR_INTERNAL_ERROR,
         _("Could not exec %s"), VZCTL);

NB, we have to use a %s format string when going via gettext rather than
just allowing the preprocessor to do string concatenation for us.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]