[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix diagnostic when execute openvz commands



On Wed, Jul 09, 2008 at 02:25:10PM +0400, Evgeniy Sokolov wrote:
> >This really needs to be changed to pass through gettext, eg
> >
> >   error(dom->conn, VIR_ERR_INTERNAL_ERROR,
> >         _("Could not exec %s"), VZCTL);
> >
> >NB, we have to use a %s format string when going via gettext rather than
> >just allowing the preprocessor to do string concatenation for us.
> 
> Ok, it need. Thanks!
> 
> fixed patch is attached.

ACK, this looks good to me now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]