[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix up dom-name validation



On Thu, Jul 10, 2008 at 05:07:07AM +0100, John Levon wrote:
> 
> libvirt schema: improve domain name regex

  Cool, thanks, applied !

> This regexp is based upon what xend actually allows, plus the existing
> &, which I presume is there for a reason.

  Hum, well, I used that to make sure names characters were properly
escaped too when converting to XML. Actually in practice & is unlikely
(though other hypervisors than Xen may allow that character) and other
XML escaped characters are even less likely because they would be a 
major pain to use from a command line level, but I would prefer to keep
that test case (tests/xmconfigdata/test-escape-paths.cfg and xml).

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]