[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] bug in libvirt.c?



On Thu, Jul 10, 2008 at 06:49:22PM +0400, Evgeniy Sokolov wrote:
>  for (i = 0; i < virNetworkDriverTabCount; i++) {
>                 if ((virDriverTab[i]->probe != NULL) &&
>                     ((latest = virDriverTab[i]->probe()) != NULL)) {
>                     probes++;
> 
>                  .....
>                 }
>  }
> 
> We use array virDriverTab, but cicle is to virNetworkDriverTabCount 
> which count number of virNetworkDriverTab drivers.
> I think virDriverTabCount should be used.

Yes it should.

So basically our auto-probe was only checking the first 3 drivers 
(we have network drivers registered from qemu, test & remote) 

>
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]