[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 2/14: Generic network XML parser/formatter



On Wed, Jul 09, 2008 at 04:34:39PM +0200, Jim Meyering wrote:
> Modulo some minor problems, ACK.
> Even though I reviewed only the incremental diffs, there was a bit of
> new material.  BTW, nice catch, with the new uses of virBufferEscapeString.
> 
> > +virNetworkDefPtr virNetworkDefParseNode(virConnectPtr conn,
> > +                                        xmlDocPtr xml,
> > +                                        xmlNodePtr root)
> > +{
> > +    xmlXPathContextPtr ctxt = NULL;
> > +    virNetworkDefPtr def = NULL;
> > +
> > +    if (!xmlStrEqual(root->name, BAD_CAST "network")) {
> > +        virNetworkReportError(conn, VIR_ERR_INTERNAL_ERROR,
> > +                              "%s", _("incorrect root element"));
> > +        goto cleanup;
> > +    }
> 
> No big deal, but the above goto could be "return NULL;".

I've made this change, and all the others suggested, and committed
this patch. I've also made the equivalent changes to the domain XML
patch.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]