[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] Re: [PATCH] remove unnecessary "V = NULL; " stmts after VIR_FREE(V)



On Thu, Jul 17, 2008 at 12:11:13PM +0200, Jim Meyering wrote:
> Doing a review (in progress), I spotted one of these, so went in search of
> others.  They're harmless, so this is more a heads up than anything else.
> I am happy to defer application until the patch queue has been reduced.
> 
> From d97af7667699529c216835d806d1f0c6f698a70d Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Thu, 17 Jul 2008 12:05:44 +0200
> Subject: [PATCH] remove unnecessary "V = NULL;" stmts after VIR_FREE(V)
> 
> * src/domain_conf.c (virDomainChrDefParseXML)
> (virDomainNetDefParseXML): Likewise.
> * src/iptables.c (iptRuleFree): Likewise.
> * src/storage_backend.c (virStorageBackendRunProgRegex): Likewise.
> * src/test.c (testOpenFromFile): Likewise.
> * src/xm_internal.c (xenXMAttachInterface): Likewise.
> * src/xml.c (virDomainParseXMLOSDescHVM): Likewise.
> * src/xmlrpc.c (xmlRpcCallRaw): Likewise.

ACK for all except the two that touch  xm_internal.c, and xml.c since
they'll cause really painful conflicts with my Xen driver refactoring,
and chances are I've removed them anyway.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]