[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix pool-create for netfs format 'auto'



On Wed, Jul 16, 2008 at 01:30:33PM -0400, Cole Robinson wrote:
> Trying to pool-create a netfs pool with the format type
> 'auto' (as in, to autodetect the format) runs the command
> 
> mount -t auto munged-source-path
> 
> '-t auto' seems to do its job for regular file systems, but
> actually fails with nfs or cifs (I assume anything that required
> an external mount program). Strangely though, the command
> 
> mount munged-source-path
> 
> will do the right thing.
> 
> The attached patch fixes the generated command to work in
> the above case, fully removing the '-t type' piece if auto
> is specified for a netfs pool.
> 
> I tested the intended case, as well as regular fs pools
> format=auto, and netfs format=nfs, and all seemed to work
> fine.

ACK. I actually thought we'd fixed this already, since Chris
came across it a while back..

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]