[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: Add floppy support to xm_internal



On Fri, Jul 18, 2008 at 05:31:27PM +0100, John Levon wrote:
> On Fri, Jul 18, 2008 at 02:05:06PM +0200, Chris Lalancette wrote:
> 
> > What this actually means is that we shouldn't parse the floppy stuff to put it
> > in the "disks =" section of the /etc/xen configuration file, since it doesn't
> > have meaning there.  Instead, floppy disks go at the top-level of a Xen config
> > file, like:
> 
> Hmm, is your patch so complicated just because you have to support
> /etc/xen .py style output on your old Xen versions?

Yep, we need both cases in fact - the SEXPR stuff you show below
for creating live domains, or inactive domains on Xen > 3.0.4. Or
the stuff Chris does is just for inactive domains on Xen < 3.0.4
in /etc/xen style format.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]