[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] parse container id in separate function



On Mon, Jul 21, 2008 at 03:07:31PM +0400, Evgeniy Sokolov wrote:
> >On Mon, Jul 21, 2008 at 01:41:27PM +0400, Evgeniy Sokolov wrote:
> >>>On Fri, Jul 18, 2008 at 07:16:25PM +0100, Daniel P. Berrange wrote:
> >>> Right, let's reuse it, but I notice we are using strtol() in a lot of
> >>>places ...openvz driver is not the worse here especially since it has
> >>>already an encapsulating function.
> >>I did not know about virStrToLong_i(). Thanks.
> >>Also, I think it would be convenient to create simple function
> >>
> >>int
> >>virStrToLongSimple_i(const char *str, int *result)
> >>{
> >>    char *endptr;
> >>
> >>    return virStrToLong_i(str, &endptr, 10, result);
> >>}
> >
> >If you don't want to deal wit the  endptr return value, you can simply
> >pass in NULL for that param.
> 
> from notes:
> When END_PTR is NULL, the byte after the final valid digit must be NUL.
> 
> I don't want to deal the endptr. But I want to parse strings like
> "   123   abc".

Why ? Everywhere else in libvirt treats that as mal-formed input and
rejects it.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]