[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 13/14: Convert XM driver XML parser to generic API



On Tue, Jul 08, 2008 at 05:41:46PM +0100, Daniel P. Berrange wrote:
> 
> This completes the Xen driver work, replacing the code which
> converts from XML into virConfPtr objects, with code which
> converts from virDomainDefPtr into virConfPtr objects. The
> XML parsing is now fully handled by the generic routines.
> 
> At this point, the xml.c file no longer contains any Xen
> specific code and is solely generic XML routines.

[...]
> --- a/src/xend_internal.c	Thu Jul 03 16:50:10 2008 +0100
> +++ b/src/xend_internal.c	Thu Jul 03 16:50:15 2008 +0100

  okay the SExpr output routines gets refactored a bit.


  In general the diffs are really hard to follow on that patch

> +usb = 1
>  usbdevice = "mouse"

  Looks fine,

  +1

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]