[libvirt] [PATCH] virsh edit command

[Richard W.M. Jones]

On Tue, Jul 29, 2008 at 05:27:09PM +0100, John Levon wrote:
> On Tue, Jul 29, 2008 at 05:25:57PM +0100, Daniel P. Berrange wrote:
> 
> > > I actually started at one point on a graphical libvirt XML editor,
> > > although I fairly quickly realised it would be a Sisyphean task
> > > because the format isn't tremendously well defined[1] and it keeps
> > > changing.  Also because there's a lot of overlap between virt-install
> > > and (potential) virt-config-editor.
> > > 
> > > I do genuinely think that having 'virsh edit' is better than the
> > > current situation.  Currently the advice that everyone gives is to do:
> > > 
> > >   virsh dumpxml foo > foo.xml
> > >   vi foo.xml
> > >   virsh define foo.xml
> > > 
> > > which is of course precisely the same as what 'virsh edit' does :-)
> > 
> > Yes, I think this command is worthwhile adding. We should also try to
> > address the problem that John raises too, but I see that as a parallel
> > task - and a far more involved piece of work to undertake :-)
> 
> Right, and it'll probably never happen if we band-aid over the problem.
> Ah well.

Well, I take your point here, and if you really think 'virsh edit' is
a bad idea then perhaps we can do something else (give it another
name?).

Do you think a graphical libvirt XML format editor is a good solution?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v