[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]show the autostart status when displaya'virsh dominfo'.



On Mon, Jun 02, 2008 at 07:03:15AM -0400, Daniel Veillard wrote:
> On Mon, Jun 02, 2008 at 10:39:36AM +0100, Richard W.M. Jones wrote:
> > On Wed, May 28, 2008 at 02:18:50PM +0100, Daniel P. Berrange wrote:
> > > On Wed, May 28, 2008 at 11:21:05AM +0900, Atsushi SAKAI wrote:
> > > > Hi, Rich and Dan 
> > > > 
> > > > Thank you for fixing this.
> > > > I think it should be noted about submitting patch on HACKING file or others.
> > > > How do you think?
> > > > (like make check; make syntax-check; make tests)
> > > 
> > > Yes, basically the three things you should run before committing patches
> > > are
> > > 
> > >     make check
> > >     make syntax-check
> > >     make valgrind        (in the tests/ sub-dir)
> > > 
> > > The latter checks for memory leaks.
> > > 
> > > Of course I myself forget this often - which is why we have the automated
> > > nightly builds, so we never miss the problem for longer than a day
> > 
> > Suggested patch to HACKING file.
> 
>   Nice writeup ! +1

Committed this.  It's probably not perfect, so feel free to fix any
problems ...

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]