[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Question about compilation on MinGW(StorageAPI)



On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
> Hi, Dan 
> 
> If remove uncompiled code on MinGW, the patch seems like this.
> 
> 0)siginfo_t does not have.
> 1)MinGW does not have waitpid, fork etc.
> 2)add testutilsqemu.c to check WITH_QEMU
> 
> I need to investigate more?
> (Please wait a week, if need to investigate this.)
> 
>  src/driver.h          |    4 ++++
>  src/internal.h        |    4 ++++
>  src/libvirt.c         |    3 ++-

I don't like this change - we should disable all the virStateXXX
funtions, based on #ifdef WITH_LIBVIRTD, since they're only used
when in daemon mode, and thus avoid a #ifndef WIN32

>  tests/testutils.c     |    9 ++++++++-

This change will cause the virshtest  test file to fail every time on win32.

The better way to approach this is to wrap the *entire* of 

 virtTestCaptureProgramOutput


in #ifndef WIN32, and then in the virshtest.c file disable the entire
test suite, 

   #ifndef WIN32
    ....normal test code...
   #else
   int main (void) { return (77); /* means 'test skipped' for automake */ }
   #endif


See  qemuxml2argvtest.c for an example of this.

>  tests/testutilsqemu.c |    2 ++

This is fine.

Regards,
Daniel.
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]