[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] qemudDomainSetMemory() / qemudDomainSetVcpus() error codes



Daniel P. Berrange wrote:
On Thu, Jun 05, 2008 at 03:38:46PM -0700, Kaitlin Rupert wrote:
Hello,

I noticed qemudDomainSetMemory() / qemudDomainSetVcpus() use the VIR_ERR_INTERNAL_ERROR error code when the caller attempts to set the mem/vcpus of an active domain.

In this case, returning something like VIR_ERR_NO_SUPPORT would indicate that this is an invalid call - which would distinguish the error from a failure that occurred during the call.

Yes, that would be a better choice in this scenario. Patches welcomed to
changed this :-)

Dan.


Thanks!  Just sent a patch for it.  Sorry for the late follow-up. =)

--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin linux vnet ibm com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]