[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Question about compilation on MinGW(StorageAPI)



Hi, Dan

Additional Info
I change libtool version from 1.5.18 to 1.5.26.
Then make install process is passed.

I will post whole compilation process on MinGW after I completed.

At this moment, current patch seems to be enough for MinGW.

Thanks
Atsushi SAKAI


Atsushi SAKAI <sakaia jp fujitsu com> wrote:

> Hi, Dan 
> 
> How about this?
> 
> With this patch, 
> make, 
> make check, 
> make syntax-check on libvirt is running (some test are skipped.).
> At this moment "make install" is failed on virsh install like this.
> The output is like thisat src directory
> 
> # ../libtool --mode=install /usr/bin/install -c 'virsh.exe' '/usr/local/bin/virsh.exe'
> ../libtool: ./virsh.: No such file or directory
> 
> I am investigating this issue at this moment.
> 
> 
>  qemud/Makefile.am     |    2 ++
>  src/driver.h          |    4 ++++
>  src/internal.h        |    2 ++
>  src/libvirt.c         |    4 ++++
>  src/qemu_driver.c     |    8 ++++++++
>  src/remote_internal.c |    6 ++++++
>  tests/Makefile.am     |    9 ++++++---
>  tests/testutils.c     |    5 ++++-
>  tests/testutilsqemu.c |    3 ++-
>  tests/virshtest.c     |    7 ++++++-
>  10 files changed, 44 insertions(+), 6 deletions(-)
> 
> Thanks
> Atsushi SAKAI
> 
> 
> 
> "Daniel P. Berrange" <berrange redhat com> wrote:
> 
> > On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
> > > Hi, Dan 
> > > 
> > > If remove uncompiled code on MinGW, the patch seems like this.
> > > 
> > > 0)siginfo_t does not have.
> > > 1)MinGW does not have waitpid, fork etc.
> > > 2)add testutilsqemu.c to check WITH_QEMU
> > > 
> > > I need to investigate more?
> > > (Please wait a week, if need to investigate this.)
> > > 
> > >  src/driver.h          |    4 ++++
> > >  src/internal.h        |    4 ++++
> > >  src/libvirt.c         |    3 ++-
> > 
> > I don't like this change - we should disable all the virStateXXX
> > funtions, based on #ifdef WITH_LIBVIRTD, since they're only used
> > when in daemon mode, and thus avoid a #ifndef WIN32
> > 
> > >  tests/testutils.c     |    9 ++++++++-
> > 
> > This change will cause the virshtest  test file to fail every time on win32.
> > 
> > The better way to approach this is to wrap the *entire* of 
> > 
> >  virtTestCaptureProgramOutput
> > 
> > 
> > in #ifndef WIN32, and then in the virshtest.c file disable the entire
> > test suite, 
> > 
> >    #ifndef WIN32
> >     ....normal test code...
> >    #else
> >    int main (void) { return (77); /* means 'test skipped' for automake */ }
> >    #endif
> > 
> > 
> > See  qemuxml2argvtest.c for an example of this.
> > 
> > >  tests/testutilsqemu.c |    2 ++
> > 
> > This is fine.
> > 
> > Regards,
> > Daniel.
> > -- 
> > |: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
> > |: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
> > |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> > |: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]