[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1 of 3] [LXC] Add functions to manage veth device pairs



Dan Smith wrote:
>>> +    if (1 > strlen(veth1)) {
> 
> DL> Why do you check with strlen > 1 ?
> 
> To be honest, I have no idea why Dave did that.  I'll check with him
> to see if there's something we're missing.  It's probably worth a
> comment if so.
> 

So that's checking if veth1 is an empty string and hence needs to have a name
assigned.  I don't recall any special reason for using (1 > strlen()).

-- 
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]