[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Eliminate noise from python type wrappers




Hi,

We recently had a virt-install build failure when someone tried building on a system with debug libvirt packages installed. It was caused by extra noise from commands that load libvirt. For example:

$ python ./setup.py --version
libvirt_virConnectPtrWrap: node = 8938fb8
0.300.3

I've seen (internal) complaints about this, and I think the irritation from the noise outweighs the usefulness of these statements, so they should be removed.

Signed-off-by: Ryan Scott <ryan scott sun com>


--- python/types.c.orig	2008-06-10 11:15:40.372795533 -0700
+++ python/types.c	2008-06-24 11:21:25.825967564 -0700
@@ -20,10 +20,6 @@ PyObject *
 libvirt_intWrap(int val)
 {
     PyObject *ret;
-
-#ifdef DEBUG
-    printf("libvirt_intWrap: val = %d\n", val);
-#endif
     ret = PyInt_FromLong((long) val);
     return (ret);
 }
@@ -32,10 +28,6 @@ PyObject *
 libvirt_longWrap(long val)
 {
     PyObject *ret;
-
-#ifdef DEBUG
-    printf("libvirt_longWrap: val = %ld\n", val);
-#endif
     ret = PyInt_FromLong(val);
     return (ret);
 }
@@ -44,10 +36,6 @@ PyObject *
 libvirt_ulongWrap(unsigned long val)
 {
     PyObject *ret;
-
-#ifdef DEBUG
-    printf("libvirt_ulongWrap: val = %lu\n", val);
-#endif
     ret = PyLong_FromLong(val);
     return (ret);
 }
@@ -56,10 +44,6 @@ PyObject *
 libvirt_longlongWrap(long long val)
 {
     PyObject *ret;
-
-#ifdef DEBUG
-    printf("libvirt_longWrap: val = %ld\n", val);
-#endif
     ret = PyLong_FromUnsignedLongLong((unsigned long long) val);
     return (ret);
 }
@@ -73,9 +57,6 @@ libvirt_charPtrWrap(char *str)
         Py_INCREF(Py_None);
         return (Py_None);
     }
-#ifdef DEBUG
-    printf("libvirt_xmlcharPtrWrap: str = %s\n", str);
-#endif
     ret = PyString_FromString(str);
     free(str);
     return (ret);
@@ -90,9 +71,6 @@ libvirt_constcharPtrWrap(const char *str
         Py_INCREF(Py_None);
         return (Py_None);
     }
-#ifdef DEBUG
-    printf("libvirt_xmlcharPtrWrap: str = %s\n", str);
-#endif
     ret = PyString_FromString(str);
     return (ret);
 }
@@ -106,9 +84,6 @@ libvirt_charPtrConstWrap(const char *str
         Py_INCREF(Py_None);
         return (Py_None);
     }
-#ifdef DEBUG
-    printf("libvirt_xmlcharPtrWrap: str = %s\n", str);
-#endif
     ret = PyString_FromString(str);
     return (ret);
 }
@@ -118,9 +93,6 @@ libvirt_virDomainPtrWrap(virDomainPtr no
 {
     PyObject *ret;
 
-#ifdef DEBUG
-    printf("libvirt_virDomainPtrWrap: node = %p\n", node);
-#endif
     if (node == NULL) {
         Py_INCREF(Py_None);
         return (Py_None);
@@ -136,9 +108,6 @@ libvirt_virNetworkPtrWrap(virNetworkPtr 
 {
     PyObject *ret;
 
-#ifdef DEBUG
-    printf("libvirt_virNetworkPtrWrap: node = %p\n", node);
-#endif
     if (node == NULL) {
         Py_INCREF(Py_None);
         return (Py_None);
@@ -154,9 +123,6 @@ libvirt_virStoragePoolPtrWrap(virStorage
 {
     PyObject *ret;
 
-#ifdef DEBUG
-    printf("libvirt_virStoragePoolPtrWrap: node = %p\n", node);
-#endif
     if (node == NULL) {
         Py_INCREF(Py_None);
         return (Py_None);
@@ -172,9 +138,6 @@ libvirt_virStorageVolPtrWrap(virStorageV
 {
     PyObject *ret;
 
-#ifdef DEBUG
-    printf("libvirt_virStorageVolPtrWrap: node = %p\n", node);
-#endif
     if (node == NULL) {
         Py_INCREF(Py_None);
         return (Py_None);
@@ -190,9 +153,6 @@ libvirt_virConnectPtrWrap(virConnectPtr 
 {
     PyObject *ret;
 
-#ifdef DEBUG
-    printf("libvirt_virConnectPtrWrap: node = %p\n", node);
-#endif
     if (node == NULL) {
         Py_INCREF(Py_None);
         return (Py_None);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]