[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] fix another bug exposed by a compiler warning



On Mon, 2008-03-03 at 17:35 +0100, Jim Meyering wrote:

> -    virerr = __virErrorMsg(code, (errorMessage[0] ? errorMessage[0] : NULL));
> +    virerr = __virErrorMsg(code, (!errorMessage[0] ? errorMessage : NULL));

	That can't be right, surely? You mean:

  (errorMessage[0] ? errorMessage : NULL)

	right?

	(Otherwise you'd only ever be passing "" or NULL to virErrorMsg)

Cheers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]