[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Don't make connection read-only when non-root

On Sun, Mar 09, 2008 at 09:05:02PM +0000, Daniel P. Berrange wrote:
> The virsh commands has long forced the connection to be read-only if running
> as non-root. This is bogus because it is perfectly capable of authenticating
> full read-write connections as non-root since we gained kerberos/policykit
> support. The user can always use the explicit --readonly flag if they only
> want a read only connection
> Dan.
> Index: src/virsh.c
> ===================================================================
> RCS file: /data/cvs/libvirt/src/virsh.c,v
> retrieving revision 1.135
> diff -r1.135 virsh.c
> 6048,6054d6047
> < #ifndef __MINGW32__
> <     /* Force a non-root, Xen connection to readonly */
> <     if ((ctl->name == NULL ||
> <          !strcasecmp(ctl->name, "xen")) && ctl->uid != 0)
> <          ctl->readonly = 1;
> < #endif

Yes.  I was tempted to just remove this bogosity before but instead I
just patched it out for Windows.


Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]